Feedback on the new pDEX

[Jerry_Watson]

I get what you are saying, but I see a lot of topics on here that say, “I tried to send DAI, but my 60 min timer dropped, maybe an estimated fee that says, “choose this fee to avoid any time issues” or something?

[ning]

Hey - that’s a fair assumption, but the above issue (say, DAI deposit from Ethereum chain) has nothing to do with incognito tx fees that users set. If you’ll note, a shield request doesn’t incur fees from the user side at all. Issues are typically due to congestion on ETH side/insufficient gas fees paid to Ethereum miners/some inefficiency on the Incognito backend.

[ning]

@Kelsomatic

When selecting a coin to trade it would be cool to have a search option available.

sorry, might be misunderstanding you - but there is currently already a search option available. see below:

or do you mean it’s not clear from the hint text ‘Select token to sell’ that it’s a searchable field?

@Kelsomatic

The slippage warning is not visible when the keyboard is displayed on screen…see attached screenshots. This may cause users to miss the warning.

thanks. i’ll speak with the team about it today.

[Mike_Wagner]

@ning

‘Select token to sell’ that it’s a searchable field?

I wouldn’t have thought that was a search input based on that text. A better prompt might be “Search tokens” or even just “Search”.

[ning]

yeah agreed, will change.

[ning]

hey @abduraman @Kelsomatic @doc, @Gold - thanks for your feedback. we’re gonna bring pool size back. definitely helpful information for traders to make their own decision about slippage and whatnot, and may help liquidity providers make decisions too.

[Mike_Wagner]

@ning

For what it’s worth, this is what that looks for me on my iPad:

I didn’t even know there was text there. The text is so light there’s barely any contrast with the white background.

[ning]

thanks mike - will fix also. appreciate it

[Kelsomatic]

Thank you @ning. I didn’t realize it was searchable. Nice work, happy to see the team is warning the trader. Looking forward to pkyber and pUniswap integration

[abduraman]

I think iOS issue. My iPhone 8 Plus shows in the same way.

[abduraman]

@abduraman

@ning

currently, this fee is fixed slightly higher to account for different eventualities and ensure the trade does not fail.

Thanks for answers @ning. For this question, my concern was not fee. The explorer shows 2e-9 as the transaction fee ok but where does the remaining part of the deducted fee go? To DAO or to liquidity providers or to somewhere else?

Maybe you’re looking for an answer. Sorry for bothering you again but the answer is important to me. Thanks. @ning

[tien]

It’s stored in an temp wallet address. Which belong to noone. When user make a trade action, multiple transactions is created to hide user’s identity, not just only trade transaction. So the tx fee is set to high to make sure all transactions never fail because of the fee.

Below is how trade works
User -> Temp Wallet -> Trade -> Temp Wallet -> User

Note: Each trade quest use unique temp wallet address.

[abduraman]

@tien

Which belong to noone.

This means that the max supply of PRV decreases in each trade. Am I wrong? @tien

@tien

multiple transactions is created to hide user’s identity

These transactions are not seen in incscan explorer, aren’t they? Are they hidden?

[tien]

1. Yeah, the max supply of PRV decreases in each trade. I think we will implement a way to send back prv left to the user
2. They can be seen in incscan explorer. You just don’t know what tx is your

[abduraman]

Why is trading so slow in the new pDEX? In the old pDEX, my trades were completed within at most 5 minutes. Let me define the completeness: the time between when trade is submitted and when the bought amount is seen in the balance. In the new pDEX, this takes at least 10 minutes. Why?

Furthermore, the trade notifications works incorrectly. The notification says “your balance updated”. However, I have to wait for the balance update for 1 minute or so.

[ELDAD]

Exactly. Trading experience is so sloooww

[tien]

1. Because the new pDex make a full flow of trade: Deposit -> Trade -> Withdraw. So it will take longer than just Trade. We’re improving it by using the same shard wallet as temp wallet. The waiting time will be reduced by 5 minutes / trade

2. The reason you need to wait for 1 minute for balance update is our blockchain structure. Our blockchain is shard blockchain. It has 8 shards. One account will belong to a shard. If two accounts A and B in same shard, their balance will be updated right away after transaction is confirmed. But if they are in different shard, they will need to wait for 1-3 minutes to get the update. So that’s why you need to wait for 1 minute because the temp wallet can be in different shard. We will fix this with above solution.

[doc]

@tien

1. The reason you need to wait for 1 minute for balance update is our blockchain structure. Our blockchain is shard blockchain. It has 8 shards. One account will belong to a shard. If two accounts A and B in same shard, their balance will be updated right away after transaction is confirmed. But if they are in different shard, they will need to wait for 1-3 minutes to get the update. So that’s why you need to wait for 1 minute because the temp wallet can be in different shard. We will fix this with above solution.

This is probably a conveyance issue then, and might want to consider adjusting the wording in conformation to say something like “Trade completed, balance will update within 3 minutes”

[tien]

Thank for your idea, we will consider it. Actually, after the improvement, your balance is updated when you receive the notification

[doc]

@tien

Thank for your idea, we will consider it. Actually, after the improvement, your balance is updated when you receive the notification

Even better!